Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the path to .neptune folder absolute #1391

Merged
merged 19 commits into from
Jul 14, 2023
Merged

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Jul 7, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -6.34 ⚠️

Comparison is base (382811b) 79.49% compared to head (a8db9d2) 73.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1391      +/-   ##
==========================================
- Coverage   79.49%   73.15%   -6.34%     
==========================================
  Files         279      279              
  Lines       13859    13568     -291     
==========================================
- Hits        11017     9926    -1091     
- Misses       2842     3642     +800     
Flag Coverage Δ
e2e ?
e2e- ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 72.85% <100.00%> (-6.42%) ⬇️
macos-latest ?
py3.10 ?
py3.7 73.15% <100.00%> (-5.85%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 73.01% <100.00%> (-6.27%) ⬇️
ubuntu-latest ?
unit 73.15% <100.00%> (-0.60%) ⬇️
windows 72.29% <100.00%> (-7.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../operation_processors/async_operation_processor.py 87.33% <100.00%> (+0.08%) ⬆️
...peration_processors/offline_operation_processor.py 92.85% <100.00%> (+0.26%) ⬆️
...internal/operation_processors/operation_storage.py 90.32% <100.00%> (-0.86%) ⬇️
...l/operation_processors/sync_operation_processor.py 94.28% <100.00%> (+0.16%) ⬆️

... and 107 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AleksanderWWW AleksanderWWW marked this pull request as ready for review July 7, 2023 14:32
@AleksanderWWW AleksanderWWW merged commit 0071cbb into master Jul 14, 2023
@AleksanderWWW AleksanderWWW deleted the aw/fix-op-cleaning branch July 14, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Changing .neptune location is broken with NeptuneLogger
2 participants