Do not forward every attribute from Handler to Attribute #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnela
commented
Jan 13, 2022
neptune/new/handler.py
Outdated
| if attr: | ||
| return getattr(attr, function_name)(**kwargs) | ||
| else: | ||
| raise AttributeError(f"No such method '{function_name}'.") |
There was a problem hiding this comment.
I was thinking that we could add some information, that there's no such method, because field is not "initialized" yet, but:
- it's quite due to our internal implementation, and probably this should be not user facing info
- I wanted to keep behaviour compliant with the previous one
shnela
commented
Jan 13, 2022
| def test_missing_attribute(self): | ||
| exp = self.call_init(mode="debug") | ||
| with self.assertRaises(MissingFieldException): | ||
| exp["non/existing/path"].fetch() |
There was a problem hiding this comment.
Waiting for @Herudaio accept.
pkasprzyk
reviewed
Jan 17, 2022
pkasprzyk
approved these changes
Jan 17, 2022
|
LGTM -- please update changelog and you can merge it |
shnela
force-pushed
the
jk/handler-to-attribute-forwarding
branch
from
736b15f
to
c69e5be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.