Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching all listed tags instead of any when calling #899

Merged
merged 3 commits into from
May 16, 2022
Merged

Matching all listed tags instead of any when calling #899

merged 3 commits into from
May 16, 2022

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented May 16, 2022 •
edited
Loading

Closes #898

aniezurawski
aniezurawski previously approved these changes May 16, 2022
View reviewed changes
@Raalsky Raalsky merged commit ee1d10f into master May 16, 2022
@Raalsky Raalsky deleted the rj/fetch-runs branch May 16, 2022 09:06
normandy7 pushed a commit that referenced this pull request May 23, 2022
@Raalsky @normandy7
Matching all listed tags instead of any when calling (#899)
7ca4117
@wjaskowski
Copy link
Contributor

Do I understand correctly that with this change I need to specify all the tags of a given run to successfully fetch it? If so, this is a disaster.

@aniezurawski
Copy link
Contributor

@wjaskowski No. Run matches if it contains all tags passed as a filter instead of any of them. No need to pass all tags that Run contains.

@wjaskowski
Copy link
Contributor

Oh. I see. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniezurawski aniezurawski aniezurawski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Inconsistency in fetch_run_table tag selector
3 participants
@Raalsky @wjaskowski @aniezurawski