Support multiple results in NeptuneObserver completed_event() #68
Conversation
|
@david1309 thanks! |
neptunecontrib/monitoring/sacred.py
Outdated
| for i, r in enumerate(result): | ||
| if isinstance(r, float): | ||
| neptune.log_metric(f'result_{i}', r) | ||
| else: # Ignore non float results # TODO: Find a way of logging objects (log_artifact maybe??) |
There was a problem hiding this comment.
Yes @david1309, you can log objects either via log_artifact on a path to a pickled object or you could use neptunecontrib.monitoring.utils.pickle_and_send_artifact(obj, 'name.pkl') which pickles to a temporary path and sends that to Neptune.
There was a problem hiding this comment.
Good to know, as some objects I want to store don't actually have a path / pickle associated to them, so this pickle_and_send_artifact is a nice wrapper
|
Thanks a lot @david1309 for PR-ing this. BTW, any other ideas that could help you with Sacred+Neptune? |
changed from formatting with f-strings to ` .format(i)` + using `pickle_and_send_artifact()`for logging objects **Issue**: if the result is a single result and its an object, the initial `if result:` will evaluate to `false` and nothing will be logged
|
I am so sorry @david1309 but it seems that there is some wrong formatting in that Could you please make sure that the formatting as specified by pip install -q -r test_requirements.txtand then python -m pylint -j 0 -f parseable neptunecontrib testsI know it wasn't written anywhere other than in |
fixed formatting
|
@david1309 figured I'd help with the formatting. |
|
Glad it worked, thanks for the formatting. Btw, what I said about "if the result is a single result and its an object, the initial Regarding any other improvements for Neptune - sacred integration tbh I don't have any suggestions atm since I haven't use these tools in integration too much ... i'll let you know if I think of something else |
|
@david1309 @jakubczakon thanks for this contribution :) |
When using sacred the
resultvariable can be either a float (whichNeptuneObservercode currently supports) or multiple results (a tuple, which causes a crash do toneptune.log_metrics()not supporting tuples).This is a quick fix I made ... but it would be nice that if one of the elements of the tuple is object (e.g. If parts of my results is a buffer / dataset) I could also store it