Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering bug #112

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Fix rendering bug #112

merged 3 commits into from
Jan 31, 2024

Conversation

liruilong940607
Copy link
Collaborator

@liruilong940607 liruilong940607 commented Jan 31, 2024

fix #111

The get_tile_bin_edges_tensor defined in the bindings is buggy -- tile_bins should be with shape (num_tiles, 2), not (num_intersects, 2).

@liruilong940607
Copy link
Collaborator Author

liruilong940607 commented Jan 31, 2024

The above commit fix rendering from
image
to
ref

But the bottom right corner is still buggy

@liruilong940607
Copy link
Collaborator Author

liruilong940607 commented Jan 31, 2024

The above commit fix the rendering to

image

@vye16 My understanding is this 0.5f is to account for the half pixel size but I'm not sure whether it should be +0.5 or -0.5. Just flipping it makes the bug go away. Let me know if you think the original one is the correct way then the we need to fix it from somewhere else.

@liruilong940607
Copy link
Collaborator Author

All tests pass locally

Copy link
Collaborator

@vye16 vye16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch, this is super helpful, sorry it was buggy for so long

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure, in the original release, it was +0.5, but then in #91 test case, the pixel difference was off by the wrong sign for a single gaussian at the center so flipped it to -0.5. maybe just use +0.5 for now

@vye16 vye16 merged commit 25be7a3 into main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG to be fixed
2 participants