Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval table #134

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Eval table #134

merged 5 commits into from
Feb 22, 2024

Conversation

AdamRashid96
Copy link
Collaborator

Added eval table to the docs.

Screenshot 2024-02-22 at 3 01 03 PM

Copy link
Collaborator

@vye16 vye16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vye16 vye16 merged commit a45e203 into main Feb 22, 2024
2 checks passed
@jb-ye
Copy link
Collaborator

jb-ye commented Feb 25, 2024

Could you describe how do you process the images to generate the undistorted images and colmap project? Are you using Inria's convert.py? @AdamRashid96

@AdamRashid96
Copy link
Collaborator Author

Could you describe how do you process the images to generate the undistorted images and colmap project? Are you using Inria's convert.py? @AdamRashid96

I ran Inria's convert.py for the Mipnerf-360 dataset, and then I generated a transforms.json file with the nerfstudio formatting, so I could train nerfstudio's splatfacto with the same poses and colmap parameters.

@jb-ye
Copy link
Collaborator

jb-ye commented Feb 27, 2024

@AdamRashid96 When you convert data to nerfstudio format, did you use the undistorted or distorted colmap cameras?

One more thing is how train/val images are split. Inria use every 8th image as validation image, while nerfstudio's behavior depends on the data parser. If using colmap parser, it is the same, every 8th image. If using nerfstudio parser, it is 10% of input images.

@jb-ye
Copy link
Collaborator

jb-ye commented Feb 27, 2024

I strongly recommend to re-run splatfacto's evaluation using colmap parser after this fix: #136 properly integrated.

@ichsan2895
Copy link

Could you describe how do you process the images to generate the undistorted images and colmap project? Are you using Inria's convert.py? @AdamRashid96

I ran Inria's convert.py for the Mipnerf-360 dataset, and then I generated a transforms.json file with the nerfstudio formatting, so I could train nerfstudio's splatfacto with the same poses and colmap parameters.

Why you choose python3 convert.py instead of nerfstudio-dataparser.

FYI I have implement ns-process-data splatfacto in my own repo ichsan2895/nerfstudio. It mimics python convert.py but it compatibles with nerfstudio-dataparser because it creates sparse_pc.ply and transform.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants