-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eval table #134
Eval table #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Could you describe how do you process the images to generate the undistorted images and colmap project? Are you using Inria's convert.py? @AdamRashid96 |
I ran Inria's convert.py for the Mipnerf-360 dataset, and then I generated a transforms.json file with the nerfstudio formatting, so I could train nerfstudio's splatfacto with the same poses and colmap parameters. |
@AdamRashid96 When you convert data to nerfstudio format, did you use the undistorted or distorted colmap cameras? One more thing is how train/val images are split. Inria use every 8th image as validation image, while nerfstudio's behavior depends on the data parser. If using colmap parser, it is the same, every 8th image. If using nerfstudio parser, it is 10% of input images. |
I strongly recommend to re-run splatfacto's evaluation using colmap parser after this fix: #136 properly integrated. |
Why you choose python3 convert.py instead of nerfstudio-dataparser. FYI I have implement |
Added eval table to the docs.