Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not materialize mlp_head if no field_heads #2457

Merged

Conversation

Mxbonn
Copy link
Contributor

@Mxbonn Mxbonn commented Sep 22, 2023

In case it is used in a proposal network we avoid initializing the head.

In case it is used in a proposal network we avoid initializing the head.
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@tancik tancik enabled auto-merge (squash) September 22, 2023 15:29
@tancik tancik merged commit 52f26e8 into nerfstudio-project:main Sep 22, 2023
3 checks passed
@Mxbonn Mxbonn deleted the only_materialize_head_when_needed branch September 22, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants