Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various layout fixes #22

Merged
merged 2 commits into from
Mar 5, 2020
Merged

various layout fixes #22

merged 2 commits into from
Mar 5, 2020

Conversation

nerik
Copy link
Owner

@nerik nerik commented Mar 4, 2020

  • never pick an island that scales up to avoid ugly heights and island borders
  • use sometimes same score list for cluster children to have multiple islands with the same orientation
  • randomly place place cities inland when island is big

@nerik nerik requested a review from j8seangel March 4, 2020 18:08
Copy link
Collaborator

@j8seangel j8seangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line https://github.com/nerik/book-islands/blob/master/scripts/layout/areaLayout.js#L136 which crashes because out of memory, is the ISLANDS_LOWDEF_BUFF used anywhere ? could we remove it? apart from that LGTM

@nerik nerik merged commit 3d521de into master Mar 5, 2020
@nerik nerik deleted the no-clusters branch March 5, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants