Changing any private accessors to protected to enable customization by implementing projects
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essly prevent inheritance or customization;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing any
privateaccessors toprotected, as we must not needlessly prevent inheritance or customization.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Private accessors for
AngularTokenService&AngularTokenInterceptorcannot be modified or accessed by any inherited class, especially with the intention of extending their behavior.Issue Number: N/A
What is the new behavior?
No functional change. Simply allowing for
AngularTokenService&AngularTokenInterceptorto be used as super classes for any derived classes. Implementing projects can now add or modify member functions or properties.Does this PR introduce a breaking change?