Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing any private accessors to protected to enable customization by implementing projects #535

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

omboapp
Copy link

@omboapp omboapp commented Jan 15, 2021

Changing any private accessors to protected, as we must not needlessly prevent inheritance or customization.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Private accessors for AngularTokenService & AngularTokenInterceptor cannot be modified or accessed by any inherited class, especially with the intention of extending their behavior.

Issue Number: N/A

What is the new behavior?

No functional change. Simply allowing for AngularTokenService & AngularTokenInterceptor to be used as super classes for any derived classes. Implementing projects can now add or modify member functions or properties.

Does this PR introduce a breaking change?

  • Yes
  • No

deavon and others added 2 commits January 14, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants