Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for devices with both a mouse and touch events #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfyne
Copy link

@jfyne jfyne commented Aug 30, 2013

At the moment backbone.touch doesn't play nicely with devices that have both a touch event and a mouse available. I believe this change will help to alleviate this problem, however I don't have many devices to test on. Can you take a look and see if you think this will help?

My issue has occurred within my application with users who have a Chromebook Pixel not being able to click on any links with the mouse pad. I don't have a Chromebook Pixel to test on either, but I will be pushing out this change to my users to see if it fixes it.

Cheers!

@mvantassel
Copy link

This PR fixed an issue we had in production for a client. Thank you very much @jfyne for this!

@nervetattoo
Copy link
Owner

Thanks for the PR @jfyne, I've been too busy to have a look at this and getting it merged.
I would love it if it was possible to write a test case for this, but I will probably merge it without as well.

@nervetattoo
Copy link
Owner

Using the low level event binding methods isn't ideal imo, and I'd also prefer that this was solved by detection before attaching events, not this removing after event happened and then delegating events all over.
Event binding has a cost and this is too much binding/removing, at least when this is repeated over every view instance in an entire app which can be thousands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants