feat: new banner animation performance optimization #1235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pygman
force-pushed
the
new-banner-animation-performance-optimization
branch
3 times, most recently
from
468b019
to
9551e06
Compare
2023-04-12.00.17.40.mov
2023-04-12.00.18.25.mov |
|
Please briefly describe these two videos because it's hard to understand in which scene they are working, especially for users outside the team. |
|
And please rebase and PR to https://github.com/Magickbase/ckb-explorer-frontend/ so a preview will be deployed on vercel, as https://ckb-explorer-git-develop-magickbase.vercel.app/. With that, the functionality could be verified on customers' computers. |
pygman
force-pushed
the
new-banner-animation-performance-optimization
branch
from
9551e06
to
0dadde9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display different banner between old and new, according to the FPS