Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 424 3 #1622

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Issue 424 3 #1622

merged 4 commits into from
Feb 6, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

calculate ckb hodl wave and save to daily_statistics

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 303 lines in your changes are missing coverage. Please review.

Comparison is base (f373f6b) 67.56% compared to head (4c4cd09) 66.36%.
Report is 24 commits behind head on develop.

❗ Current head 4c4cd09 differs from pull request most recent head 86e991c. Consider uploading reports for the commit 86e991c to get more accurate results

Files Patch % Lines
app/services/portfolios/udt_accounts_statistic.rb 0.00% 83 Missing ⚠️
app/interactions/users/ckb_transactions.rb 0.00% 53 Missing ⚠️
app/controllers/validations/portfolio_signature.rb 0.00% 51 Missing ⚠️
...rs/api/v2/portfolio/ckb_transactions_controller.rb 0.00% 27 Missing ⚠️
app/controllers/concerns/cell_data_comparator.rb 73.11% 25 Missing ⚠️
...ollers/api/v2/portfolio/udt_accounts_controller.rb 0.00% 19 Missing ⚠️
app/workers/generate_cell_dependencies_worker.rb 30.76% 9 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 30.00% 7 Missing ⚠️
app/models/daily_statistic.rb 80.00% 6 Missing ⚠️
app/serializers/cell_output_serializer.rb 76.19% 5 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1622      +/-   ##
===========================================
- Coverage    67.56%   66.36%   -1.20%     
===========================================
  Files          289      309      +20     
  Lines         7944     8465     +521     
===========================================
+ Hits          5367     5618     +251     
- Misses        2577     2847     +270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@zmcNotafraid zmcNotafraid added this pull request to the merge queue Feb 6, 2024
Merged via the queue into nervosnetwork:develop with commit 11621ff Feb 6, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the issue-424-3 branch February 6, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants