feat: add assembly based interpreter loop to speeeup VM executions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxuejie
force-pushed
the
asm-interpreter
branch
from
1e44a6a
to
e709b5b
Compare
|
It's awesome but I don't understand assembly code, let's test it with ckb :) |
quake
approved these changes
May 6, 2019
|
TODO: release it to CKB and deploy it to test |
janx
approved these changes
May 6, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new assembly based interpreter loop to speed the VM in x86_64 architectures. While running our secp256k1-sha3 benchmark
Note there's still room for more optimizations(profiling shows current work has a relatively higher portion of branch mis-predictions, which can affect the performance a lot), but this PR is quite large and let's leave more optimization work to the future.