Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change args and witness to single bytes #1632

Merged
merged 11 commits into from
Sep 25, 2019
Merged

refactor: change args and witness to single bytes #1632

merged 11 commits into from
Sep 25, 2019

Conversation

quake
Copy link
Member

@quake quake commented Sep 24, 2019

  1. Change args and witness from Vec<Bytes> to Bytes
  2. Add load_script system call

@quake quake requested review from a team, yangby-cryptape and xxuejie September 24, 2019 15:08
@doitian doitian added this to 👀 Awaiting review in CKB - Pull Requests Sep 24, 2019
@doitian doitian moved this from 👀 Awaiting review to 🔴 High priority in CKB - Pull Requests Sep 25, 2019
keroro520
keroro520 reviewed Sep 25, 2019
View reviewed changes
script/src/verify.rs Outdated Show resolved Hide resolved
script/src/verify.rs Show resolved Hide resolved
CKB - Pull Requests automation moved this from 🔴 High priority to ✅ Reviewer approved Sep 25, 2019
@quake quake mentioned this pull request Sep 25, 2019
Closed
@quake
Copy link
Member Author

quake commented Sep 25, 2019

bors r=doitian,xxuejie,keroro520

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Sep 25, 2019
bors bot added a commit that referenced this pull request Sep 25, 2019
@bors @quake
Merge #1632
7abb29b 
1632: refactor: change args and witness to single bytes r=doitian,xxuejie,keroro520 a=quake

1. Change args and witness from `Vec<Bytes>` to `Bytes`
2. Add `load_script` system call

Co-authored-by: quake wang <quake.wang@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 25, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit afb926f into develop Sep 25, 2019
CKB - Pull Requests automation moved this from ✅ Reviewer approved to Done Sep 25, 2019
@bors bors bot deleted the quake/args-witnesses-vec branch September 25, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@xxuejie xxuejie xxuejie approved these changes

@keroro520 keroro520 keroro520 approved these changes

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

Assignees
No one assigned
Labels
s:ready-to-merge Status: Waiting to be merged.
Projects
CKB - Pull Requests
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@quake @doitian @xxuejie @keroro520