Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove memory cellset #1881

Merged
merged 2 commits into from
Mar 21, 2020
Merged

feat: remove memory cellset #1881

merged 2 commits into from
Mar 21, 2020

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Dec 16, 2019 •
edited
Loading

Issue

memory cellset is useless burden, nervosnetwork/ckb-bench-archived#9 shows it didn't have much effect, but will increasing amounts of memory infinity.

Proposed Changes

remove memory cellset

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/cell_set branch 2 times, most recently from e76303d to 02ece12 Compare December 29, 2019 06:24
@stale
Copy link

stale bot commented Feb 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the s:wontfix Status: Wont fix label Feb 16, 2020
@stale stale bot closed this Feb 23, 2020
@driftluo driftluo reopened this Feb 28, 2020
@stale stale bot removed the s:wontfix Status: Wont fix label Feb 28, 2020
@zhangsoledad zhangsoledad added the pinned Tell stall bot do not close this. label Mar 2, 2020
@zhangsoledad zhangsoledad marked this pull request as ready for review March 5, 2020 12:36
@zhangsoledad zhangsoledad requested review from a team and quake March 5, 2020 12:36
@zhangsoledad zhangsoledad changed the title feat: remove memory cellset [HOLD] feat: remove memory cellset Mar 5, 2020
nervos-bot[bot]
nervos-bot bot previously requested changes Mar 5, 2020
View reviewed changes
Copy link

@nervos-bot nervos-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold as requested by @zhangsoledad.

@zhangsoledad zhangsoledad mentioned this pull request Mar 6, 2020
Closed
@zhangsoledad zhangsoledad changed the title [HOLD] feat: remove memory cellset feat: remove memory cellset Mar 6, 2020
@nervos-bot nervos-bot bot dismissed their stale review March 6, 2020 04:01

Unhold as requested by @zhangsoledad.

driftluo
driftluo previously approved these changes Mar 13, 2020
View reviewed changes
quake
quake previously approved these changes Mar 19, 2020
View reviewed changes
@quake
Copy link
Member

quake commented Mar 19, 2020

bors r=driftluo,quake

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Mar 19, 2020
bors bot added a commit that referenced this pull request Mar 19, 2020
@bors @zhangsoledad
Merge #1881
3d61a93 
1881: feat: remove memory cellset r=driftluo,quake a=zhangsoledad

## Issue
memory cellset is useless burden, nervosnetwork/ckb-bench-archived#9 shows it didn't have much effect, but will increasing amounts of memory infinity.

## Proposed Changes
remove memory cellset

Co-authored-by: zhangsoledad <787953403@qq.com>
@bors
Copy link
Contributor

bors bot commented Mar 19, 2020

Build failed

doitian added a commit that referenced this pull request Mar 19, 2020
@doitian
Merge pull request #1881 from zhangsoledad/zhangsoledad/cell_set
f6ba2e8 
feat: remove memory cellset
@doitian
Copy link
Member

doitian commented Mar 19, 2020

Please rebase

   Compiling ckb-snapshot v0.30.1-pre (/home/travis/build/nervosnetwork/ckb/util/snapshot)
error[E0560]: struct `Snapshot` has no field named `cell_set`
  --> util/snapshot/src/lib.rs:88:13
   |
88 |             cell_set: self.cell_set.clone(),
   |             ^^^^^^^^ `Snapshot` does not have this field
   |
   = note: available fields are: `tip_header`, `total_difficulty`, `epoch_ext`, `store`, `proposals`, `consensus`
error[E0609]: no field `cell_set` on type `&Snapshot`
  --> util/snapshot/src/lib.rs:88:28
   |
88 |             cell_set: self.cell_set.clone(),
   |                            ^^^^^^^^ unknown field
   |
   = note: available fields are: `tip_header`, `total_difficulty`, `epoch_ext`, `store`, `proposals`, `consensus`
error: aborting due to 2 previous errors

@doitian doitian removed the s:ready-to-merge Status: Waiting to be merged. label Mar 19, 2020
@doitian doitian added the s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Mar 19, 2020
@zhangsoledad zhangsoledad dismissed stale reviews from quake and driftluo via 371302e March 19, 2020 11:44
@zhangsoledad
Copy link
Member Author

resolved

@yangby-cryptape
Copy link
Collaborator

bors r=quake,driftluo,yangby-cryptape

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Mar 20, 2020
bors bot added a commit that referenced this pull request Mar 20, 2020
@bors @zhangsoledad
Merge #1881
1d7dec1 
1881: feat: remove memory cellset r=quake,driftluo,yangby-cryptape a=zhangsoledad

## Issue
memory cellset is useless burden, nervosnetwork/ckb-bench-archived#9 shows it didn't have much effect, but will increasing amounts of memory infinity.

## Proposed Changes
remove memory cellset

Co-authored-by: zhangsoledad <787953403@qq.com>
@bors
Copy link
Contributor

bors bot commented Mar 20, 2020

Build failed

  • continuous-integration/travis-ci/push

@driftluo driftluo mentioned this pull request Mar 20, 2020
Merged
bors bot added a commit that referenced this pull request Mar 20, 2020
@bors @driftluo
Merge #1974
6af0960 
1974: test: fix test r=quake,yangby-cryptape a=driftluo

fix test fail on merge #1881 

Co-authored-by: driftluo <driftluo@foxmail.com>
@zhangsoledad
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Mar 21, 2020

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 27b1e09 into nervosnetwork:develop Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@driftluo driftluo driftluo approved these changes

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@nervos-bot nervos-bot[bot] nervos-bot[bot] left review comments

Assignees
No one assigned
Labels
pinned Tell stall bot do not close this. s:ready-to-merge Status: Waiting to be merged. s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangsoledad @quake @doitian @yangby-cryptape @driftluo