Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Log more sync and relay metrics #1958

Merged
merged 2 commits into from
Mar 26, 2020
Merged

feat: Log more sync and relay metrics #1958

merged 2 commits into from
Mar 26, 2020

Conversation

keroro520
Copy link
Contributor

Add some metrics:

  • chain:

    • blocks chain tip number
    • headers chain tip number

  • sync/relay

    • in/out messages
    • blocks_in_flight state

  • get_ancestor

    • steps, elpased, base_number, target_number

@keroro520 keroro520 requested review from a team and zhangsoledad March 9, 2020 04:41
doitian
doitian previously approved these changes Mar 19, 2020
View reviewed changes
@doitian doitian added the s:waiting-on-reviewers Status: Waiting for Review label Mar 19, 2020
@keroro520 keroro520 force-pushed the more-metrics branch 2 times, most recently from b7b7b6f to 77c119f Compare March 20, 2020 02:07
driftluo
driftluo previously approved these changes Mar 20, 2020
View reviewed changes
doitian
doitian previously approved these changes Mar 21, 2020
View reviewed changes
@doitian
Copy link
Member

doitian commented Mar 21, 2020

bors r=doitian,driftluo

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Mar 21, 2020
@bors
Copy link
Contributor

bors bot commented Mar 22, 2020

Merge conflict

@doitian
Copy link
Member

doitian commented Mar 23, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Mar 23, 2020

Merge conflict

@doitian
Copy link
Member

doitian commented Mar 23, 2020

@keroro520 please resolve conflicts

@doitian doitian added s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed s:ready-to-merge Status: Waiting to be merged. s:waiting-on-reviewers Status: Waiting for Review labels Mar 23, 2020
@keroro520 keroro520 dismissed stale reviews from doitian and driftluo via 8ffb445 March 23, 2020 11:19
@keroro520 keroro520 added s:waiting-on-reviewers Status: Waiting for Review and removed s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Mar 24, 2020
driftluo
driftluo previously approved these changes Mar 24, 2020
View reviewed changes
@doitian
Copy link
Member

doitian commented Mar 24, 2020

conflict again

@doitian doitian added s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed s:waiting-on-reviewers Status: Waiting for Review labels Mar 24, 2020
@keroro520 keroro520 added s:waiting-on-reviewers Status: Waiting for Review and removed s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Mar 25, 2020
@keroro520 keroro520 requested a review from driftluo March 25, 2020 02:30
@driftluo
Copy link
Collaborator

bors r=doitian,driftluo

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Mar 26, 2020
@bors
Copy link
Contributor

bors bot commented Mar 26, 2020

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 26e2599 into nervosnetwork:develop Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@driftluo driftluo driftluo approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
s:ready-to-merge Status: Waiting to be merged. s:waiting-on-reviewers Status: Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keroro520 @doitian @driftluo