feat: add RPC truncate #2064
Merged
feat: add RPC truncate #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
previously approved these changes
Jun 5, 2020
quake
previously approved these changes
Jun 12, 2020
doitian
requested changes
Jun 12, 2020
There was a problem hiding this comment.
- The code is a bit too complex. The chain service should provide a interface to allow setting any stored block as tip.
- Also it is better to leave the stored blocks untouched. Once a node receives a stored block, and it has better cumulative difficulty, the chain service should set tip to this new block instead.
I think the Thanks for @zhangsoledad doing some refactoring, it may be more simple. PTAL.
RPC "truncate" is to reproduce a specified environment when test. The "environment" includes tx-pool, chain, and database. So I think removing the truncated blocks from database is better. As for "sync" a stored block and the stored block has a better cumulative difficulty, It is out of this PR. |
quake
previously approved these changes
Jun 17, 2020
doitian
reviewed
Jun 17, 2020
| @@ -501,6 +501,14 @@ impl TxPoolService { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| pub(crate) async fn clear_pool(&self) { | |||
There was a problem hiding this comment.
This method also deserves an RPC method.
doitian
approved these changes
Jun 17, 2020
quake
approved these changes
Jun 19, 2020
doitian
approved these changes
Jun 22, 2020
|
bors r=quake,doitian |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenient to reproduce a specified environment when test, this PR adds RPC
truncate(target_tip_hash)to roll-back the blockchain downto the target block. It trigger the below behaviours:target_tip_hash. In short, reset the tip to the target block.