Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logger filter parse crate name leniently #2091

Merged
merged 1 commit into from
May 26, 2020
Merged

feat: logger filter parse crate name leniently #2091

merged 1 commit into from
May 26, 2020

Conversation

yangby-cryptape
Copy link
Collaborator

No description provided.

@yangby-cryptape yangby-cryptape requested review from a team, xxuejie and keroro520 May 25, 2020 03:42
doitian
doitian previously approved these changes May 25, 2020
View reviewed changes
keroro520
keroro520 previously approved these changes May 25, 2020
View reviewed changes
@yangby-cryptape yangby-cryptape dismissed stale reviews from keroro520 and doitian via 8ace26d May 25, 2020 13:48
@yangby-cryptape yangby-cryptape force-pushed the pr/logger-parse-crate-name-leniently branch from ae99dec to 8ace26d Compare May 25, 2020 13:48
quake
quake requested changes May 26, 2020
View reviewed changes
util/logger/src/lib.rs Outdated Show resolved Hide resolved
@yangby-cryptape yangby-cryptape force-pushed the pr/logger-parse-crate-name-leniently branch from 8ace26d to 3934069 Compare May 26, 2020 04:18
quake
quake reviewed May 26, 2020
View reviewed changes
util/logger/src/lib.rs Outdated Show resolved Hide resolved
@yangby-cryptape yangby-cryptape force-pushed the pr/logger-parse-crate-name-leniently branch from 3934069 to 91f449c Compare May 26, 2020 06:26
@keroro520 keroro520 requested review from quake and doitian May 26, 2020 06:41
@quake
Copy link
Member

quake commented May 26, 2020

bors r=quake,keroro520

@bors
Copy link
Contributor

bors bot commented May 26, 2020

Build succeeded:

@bors bors bot merged commit b90678b into nervosnetwork:develop May 26, 2020
@yangby-cryptape yangby-cryptape deleted the pr/logger-parse-crate-name-leniently branch July 9, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@keroro520 keroro520 keroro520 approved these changes

@xxuejie xxuejie Awaiting requested review from xxuejie

@doitian doitian Awaiting requested review from doitian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangby-cryptape @quake @doitian @keroro520