fix: should exit with error code when setup failed #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
approved these changes
Jul 30, 2020
doitian
approved these changes
Jul 31, 2020
|
bors r=quake,doitian |
bors bot
added a commit
that referenced
this pull request
Jul 31, 2020
2169: small tx-pool refactoring r=quake,doitian a=zhangsoledad proposal changes: * rename ContextualTransactionVerifier -> TimeRelativeTransactionVerifier * split NonContextualTransactionVerifier from TransactionVerifier * check syntactic correctness first before * refactory tx-pool rejection error * re-broadcast when duplicated tx submit 2197: fix: should exit with error code when setup failed r=quake,doitian a=yangby-cryptape Issue: if the config was malformed and an error was thrown in `setup_app`, the process wouldn't exit. 2198: chore: several minor changes about thread and runtime r=quake,driftluo a=yangby-cryptape - Simplify dependencies of `ckb-async-runtime`. - Use `::std::sync::Barrier` instead of `crossbeam-channel`. - Let method `ckb-async-runtime::new_runtime` more general. - Accept name prefix for threads. - Accept `tokio::runtime::Builder` as an optional parameter, so we can set options for the runtime. - After we upgrade `tokio` from 0.1 to 0.2, the thread name of `tokio` runtime threads has a redundant suffix "-". - [`tokio-0.1.x::runtime::Builder::name_prefix(...)`](https://docs.rs/tokio/0.1.22/tokio/runtime/struct.Builder.html#method.name_prefix) - [`tokio-0.2.x::runtime::Builder::thread_name(...)`](https://docs.rs/tokio/0.2.22/tokio/runtime/struct.Builder.html#method.thread_name) - Use a default thread name in logs instead of an empty string. Without color, a log record with empty thread name is a bit hard to parse. - Give name to rayon threads to improve the debuggability slightly. Co-authored-by: zhangsoledad <787953403@qq.com> Co-authored-by: Boyu Yang <yangby@cryptape.com>
|
Build failed (retrying...):
|
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: if the config was malformed and an error was thrown in
setup_app, the process wouldn't exit.