Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(script): add more complicated scripts to unit tests #3187

Merged
merged 10 commits into from
Nov 22, 2021

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Nov 17, 2021

What problem does this PR solve?

Add more complicated scripts to test the crate ckb-script.

Changes

Tip: It's better to review this PR by reviewing each commits.

  • Refactor tests.

    • test(script): convert duplicate codes into functions to simplify them (7d060aa)

      At present, to add one test has to copy a lot of duplicate codes, so do refactor first.

    • test(script): add a Makefile to make almost all test scripts to be reproducible (883b3d9)

      Before this commit, only the latest 3 scripts could be re-built to same binaries from source files.

      I add a Makefile and a README.md to record the compile environments for almost all test scripts.
      So we can re-build these scripts more easily.

      TODO: Still left 4 binaries couldn't be built from source files.

  • Add new tests.

Check List

Tests

  • Unit test

Release note

None: Exclude this PR from the release note.

@yangby-cryptape yangby-cryptape force-pushed the pr/add-tests branch 2 times, most recently from a772d14 to 883b3d9 Compare November 17, 2021 19:30
@zhangsoledad
Copy link
Member

bors r= driftluo, zhangsoledad

@bors bors bot merged commit 0b3cc66 into nervosnetwork:develop Nov 22, 2021
@yangby-cryptape yangby-cryptape deleted the pr/add-tests branch November 25, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants