Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 docker image for ckb #4256

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Dec 4, 2023

What problem does this PR solve?

Issue Number: close #4206
For MacOS, if users follow the guide to run ckb, there will be an error:

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
Illegal instruction

This PR add arm arch docker image for ckb.

Problem Summary:

What is changed and how it works?

Pair PR: nervosnetwork/ckb-docker-builder#18

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner December 4, 2023 15:10
@chenyukang chenyukang requested review from quake and removed request for a team December 4, 2023 15:10
Copy link
Collaborator

@eval-exec eval-exec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose adding a test to verify the successful execution of the Docker image on CI. It could be something like:

docker run --rm ckb_docker_image ckb --version 
docker run --rm ckb_docker_image ckb init && ckb run 

@chenyukang chenyukang added this pull request to the merge queue Dec 12, 2023
Merged via the queue into nervosnetwork:develop with commit 2f44fb0 Dec 12, 2023
31 checks passed
@doitian doitian mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ARM64 Docker Image
2 participants