fix: Migrate dialog does not show in v0.114.2

[devchenyan]

issue: Magickbase/neuron-public-issues#374

[devchenyan]

/package
Packaging for test is done in 8535546814. @devchenyan

[Danie0918]

@Keith-CY @homura Please have a review.

[silySuper]

/package
Packaging for test is done in 8585392191. @silySuper

[silySuper]

I have start 0.113.0 full node on local,and open test package above,but can not see migrate tip.

What should I do to have migrate effect?

[Keith-CY]

I have start 0.113.0 full node on local,and open test package above,but can not see migrate tip.

What should I do to have migrate effect?

Replacing the chain data(default location /Users/{User name}/Library/Application Support/Neuron/chains/testnet/data) with one synced by CKB@v0.113.0 and CKB@v0.110.2 should trigger the migration.

[silySuper]

This is my files in chains path,no testnet files.My testnet files is in node files

[Keith-CY]

This is my files in chains path,no testnet files.My testnet files is in node files

The path I mentioned above is the default one. It can be set in Settings => Data => CKB Node &Config, so you can replace the testnet/data in your custom node data directory to trigger the migration.

[silySuper]

Only internal node has this path settings,and the file name is mainnet ,not testnet.So you mean I can change this internal node path to my 0.113 testnet data ,that I can trigger the migration?

[Keith-CY]

Only internal node has this path settings,and the file name is mainnet ,not testnet.So you mean I can change this internal node path to my 0.113 testnet data ,that I can trigger the migration?

IMO, the user-specified full node(3rd option in this case) should be able to set the data directory, it may be a bug, need confirmation from @Danie0918

You can replace the data in your own node directory to trigger the migration if you're using the self-hosted node.

The migration is triggered when your active CKB node starts and it finds its data is too old. So in fact the replacement should be taken in the directory of your active/selected node.

[Danie0918]

Only internal node has this path settings,and the file name is mainnet ,not testnet.So you mean I can change this internal node path to my 0.113 testnet data ,that I can trigger the migration?

IMO, the user-specified full node(3rd option in this case) should be able to set the data directory, it may be a bug, need confirmation from @Danie0918

This should be a bug that needs to be fixed.

[silySuper]

Only internal node has th,is path settings,and the file name is mainnet ,not testnet.So you mean I can change this internal node path to my 0.113 testnet data ,that I can trigger the migration?

IMO, the user-specified full node(3rd option in this case) should be able to set the data directory, it may be a bug, need confirmation from @Danie0918

This should be a bug that needs to be fixed.

OK, @devchenyan

[yanguoyu]

Only internal node has this path settings,and the file name is mainnet ,not testnet.So you mean I can change this internal node path to my 0.113 testnet data ,that I can trigger the migration?

IMO, the user-specified full node(3rd option in this case) should be able to set the data directory, it may be a bug, need confirmation from @Danie0918

This should be a bug that needs to be fixed.

I don't think so. If the selected node is not an internal node, it can not be set the data path. At that the users start the ckb node, so we will not show the migrate dialog and show the data path. And we can not get the ckb data path, all of the ckb node and data are controlled by the users.

[silySuper]

What is the conclusion?Need to add path setting in testnet node? @Danie0918

[yanguoyu]

What is the conclusion?Need to add path setting in testnet node? @Danie0918

Migrate dialog only shows when selecting the Internal node, so you should test by selecting the Internal Node.

[silySuper]

/package
Packaging for test is done in 8655624884. @silySuper

[silySuper]

I have replace data to /Volumes/My\ Passport/ckb节点/ckb_v0.108.1_x86_64-apple-darwin-portable/testnet/data ，but can not see migrate dialog.

2024-04-12.15.21.02.mov

[silySuper]

@devchenyan please check this issue~

[devchenyan]

@devchenyan please check this issue~

@silySuper

1. Completely uninstall neuron
2. Use a low version of neuron to synchronise data
3. Use the test package to synchronise data, trigger the migration.

[silySuper]

@devchenyan please check this issue~

@silySuper

1. Completely uninstall neuron
2. Use a low version of neuron to synchronise data
3. Use the test package to synchronise data, trigger the migration.
   actually I think neuron v114.2 is the test package because of the title,does old testnet data create by old version(v108) can not trigger the migration, before which lower version can use? @devchenyan

[homura]

Suggested change

	Recommends = 'CKB recommends migrating your data into a new format',
	// https://github.com/nervosnetwork/ckb/blob/31bcecddc8ad5b7d0a30399ef55a5ce0a359bb7e/shared/src/shared_builder.rs#L79
	Recommends = 'CKB recommends migrating your data into a new format',

[silySuper]

@devchenyan please check this issue~

@silySuper

1. Completely uninstall neuron
2. Use a low version of neuron to synchronise data
3. Use the test package to synchronise data, trigger the migration.
   actually I think neuron v114.2 is the test package because of the title,does old testnet data create by old version(v108) can not trigger the migration, before which lower version can use? @devchenyan

When last version is not null and !v108 both true,can trigger the migration ?

[silySuper]

Find the reason，path should choose to testnet file，not testnet/data file.

[silySuper]

Maybe internal node data path choose can add tips to tell users which directory can be used is better @Danie0918

[Danie0918]

Maybe internal node data path choose can add tips to tell users which directory can be used is better @Danie0918

This can only be suggested to the user and may still cause this problem. Any other solutions? @devchenyan @yanguoyu

[yanguoyu]

Maybe internal node data path choose can add tips to tell users which directory can be used is better @Danie0918

This can only be suggested to the user and may still cause this problem. Any other solutions? @devchenyan @yanguoyu

I believe the user only needs to know the root directory of the ckb data, it's unnecessary to understand the meaning of each directory of the ckb data root directory.