Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dynamically built and included Module and fallback on method_m… #93

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Remove dynamically built and included Module and fallback on method_m… #93

merged 1 commit into from
Apr 18, 2018

Conversation

nesaulov
Copy link
Owner

#92

AlessandroMinali
AlessandroMinali approved these changes Apr 17, 2018
View reviewed changes
Copy link
Collaborator

@AlessandroMinali AlessandroMinali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using method_missing might be slower but it's easier to understand 👍

@nesaulov nesaulov merged commit 9f89b2d into master Apr 18, 2018
@nesaulov nesaulov deleted the remove-dynamic-module branch April 18, 2018 06:20
@nesaulov nesaulov mentioned this pull request May 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlessandroMinali AlessandroMinali AlessandroMinali approved these changes

@nulldef nulldef Awaiting requested review from nulldef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nesaulov @AlessandroMinali