Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Jxx and row parameter of the music () function again present. Old lines are being used in src/core/sound.c #1486

Closed
Kyuchumimo opened this issue Jul 13, 2021 · 1 comment
Assignees

Comments

@Kyuchumimo
Copy link

Kyuchumimo commented Jul 13, 2021

This problem was fixed here:
6ff08ee

But again, the following lines are used (see: https://github.com/nesbox/TIC-80/blob/master/src/core/sound.c):

...
252        && jumpCmd->active)
253    {
254        music_state->music.frame = jumpCmd->frame;
255        music_state->music.row = jumpCmd->beat * NOTES_PER_BEAT;
256        core->state.music.ticks = row2tick(core, track, music_state->music.row);
257        memset(jumpCmd, 0, sizeof(tic_jump_command));
258    }
...

and

...
472        for (s32 c = 0; c < TIC_SOUND_CHANNELS; c++)
473            setMusicChannelData(memory, -1, 0, 0, MAX_VOLUME, MAX_VOLUME, c);
474
475        ram->music_state.music.row = row;
476        ram->music_state.music.frame = frame < 0 ? 0 : frame;
477        ram->music_state.flag.music_loop = loop;
478        ram->music_state.flag.music_sustain = sustain;
...
@nesbox nesbox self-assigned this Jul 14, 2021
@nesbox nesbox added this to To do in dev version 0.90 via automation Jul 14, 2021
@nesbox nesbox moved this from To do to In progress in dev version 0.90 Jul 14, 2021
nesbox added a commit that referenced this issue Jul 14, 2021
@nesbox
Copy link
Owner

nesbox commented Jul 14, 2021

fixed here 28fd122
My mistake, I did a revert of another bug inaccurately, sorry
Please check it, thank you.

@nesbox nesbox closed this as completed Jul 14, 2021
dev version 0.90 automation moved this from In progress to Done Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants