(enh) Music editor: Skip over sharp column when using cursor keys #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still think it should not be possible to even "be in the column" if being in it doesn't do anything. |
joshgoebel
force-pushed
the
kb_sharpen
branch
from
caf9259
to
f400aa9
Compare
joshgoebel
changed the title
., skip sharp column with cursor
joshgoebel
force-pushed
the
kb_sharpen
branch
from
f400aa9
to
5a6be87
Compare
joshgoebel
changed the title
., skip sharp column with cursor
|
Rebased to only include the skipping behavior, which feels very nice and natural. (and tiny PR) |
|
Please disable Draft mode for the PR if it's ready |
|
Sorry! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows toggling of sharp. I guess technically it doesn't even require you to be in the column...
Resolves #1625.