fix(zig) fix template compiling and add TextureSource #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nesbox Spot on you had it, but we really should have an enum for texture source, so this adds that as well as fixes the template example. |
nesbox
reviewed
Feb 25, 2022
| const TextureSource = enum(i32) { | ||
| TILES = 0, | ||
| MAP, | ||
| VBANK1 |
There was a problem hiding this comment.
It is not necessary to use VBANK1, it can also be VBANK0.
So textri() is using an inactive vbank for rendering, maybe just call it VBANK?
There was a problem hiding this comment.
vbank(0) would use bank 1 and vbank(1) would use bank 0?
I'll reconsider the name. Technically then it'd be SCREEN_INACTIVE_VBANK or some such. :-)
nesbox
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.