Fix the error 'folder <folder> doesn't exist' under Windows XP (win32 build) #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliceisjustplaying
changed the title
nesbox
approved these changes
May 5, 2024
|
@nesbox yes repro'd on XP |
This was referenced May 5, 2024
aliceisjustplaying
added a commit
to aliceisjustplaying/TIC-80
that referenced
this pull request
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the toolchain we use for the Windows XP builds that makes stat not work and give false errors. The recommended solution is to use
GetFileAttributesExinstead. The cleanest way I see for it is to create a shim that maps to stat and conditionally #include it.Tested on a Windows XP VM, freshly compiled on Windows 11 with the
v141_xptoolchain and works.Fixes #1844, #2357, #1924.