Touch keyboard tweaks and fix #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the keyboard appear at startup, and after wakeup from suspend or activity switch. Fixes an odd first impression - "type help for help" "but how?". Prevents the first touch that makes the keyboard appear from generating a key, same for gamepad. Sorry the code is a bit tortured.
When Ctrl+R is used to start run mode, the touch keyboard is disabled. With no updates, the Ctrl or R keys were never marked as released, and the Ctrl key being held prevented the Escape key shortcut from activating when Back was pressed. Now, all touch state is cleared regardless of the mode.
|
Also, can you please change it, so that using |
|
Sure, I'll look into that when I have some more time. |
nesbox
added
bug
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is two separate changes to the touch keyboard. They can be separated and taken independently if you want.
The first is some usability stuff I encountered - making the keyboard appear at startup and after resume, and squelching the keypress that makes it appear.
The second is an issue I saw people talking about in Discord and is a pretty straightforward bug.