-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing inline-partial rendering issue... #126
Conversation
…rinting Rabl::Engine.to_s. We now render to the first format in ActionView::Template.formats to fix this
Does this work for Rails 3 and Rails 3.1? |
Hmm. I'd forgotten to check that. I've got a test-case I can check against tomorrow morning, but not tonight unfortunately. If not we can, as you suggested, split this out into 3.0 and 3.1 implementations, which is pretty straightforward. |
Yeah reply back when you know if its Rails 3 compatible as well. If it is, I am happy to pull it in! Thanks for putting this together. |
@willrjmarshall Any luck checking that this is Rails 3 compatible? |
Hey, Haven't had a chance yet! Will get onto it ASAP ;) |
willrjmarshall Any chance to test soon, would love to push this out in the next gem release. |
First thing in the AM. Sorry for the slow - been crazy-busy |
It doesn't work in Rails 3.0 - so we should split it into two blocks as with the Rails 2 split. Does anyone else have time to make this change? I'm a little stuck for time. |
I think this was ultimately fixed. Closing. |
This doesn't appear to work for me using Rails 3.2.1 and Rabl 0.5.4. It just renders the text of the rabl template file rather than producing any json.
|
This appears to be back in Rails 3.2.6 - calling this:
from an html template gives:
|
Scratch that - this works if called this way:
as per the rails 3.2 posts integration test.. never hurts to read the source! Will propose an update to the Backbone Integration section of the wiki. |
I've got a fix in for the Rails 3.1 issue discussed at #42
It was not similar to the described HAML bug, but a separate issue entirely.