-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newtonsoft.Json dependency trouble #56
Comments
You need to specify a binding redirect for Newtonsoft.Json if you are using a version different than 7.0. |
@eiriktsarpalis I have one default generated by Packet, but it strange for me that FsPickler compiled with version higher than minimal supported. What do you think, should I address this issue to Paket developers? |
Yes I've seen this. Not sure if bug or by design. On Fri, 31 Jul 2015 at 10:57 pavelhritonenko notifications@github.com
|
Bit late to the party - just trying this framework now and with a dependency on another version of Newtonsoft in my code out this is causing me headaches. Is it possible to just remove the dependency of Newtonsoft.Json from the codebase? Maybe a stupid question. Newtonsoft is MIT licensed; doesn't that mean worse comes to worse you can just use the JsonWriter and BsonWriter's as code inside the library? I know RavenDB has done this for their JSON serialisation. Not sure if you are relying on any functionality to help with F# types for example; it would simplify things a lot. |
@mvkra I once tried doing that, but the JsonWriter/Reader types depend on a significant segment of the Json.Net library. I would like to write my own JsonWriter/Reader implementations using F# at some point, I'm sure it would benefit deserialization performance. Haven't found the time to do this yet. Does adding a binding redirect not fix your problem? |
It does if I play with it right but I would rather just use Json.net then
|
Closing this old discussion/question |
I have an issue when I want to stick Newtonsoft.Json to ~6.0 version
https://github.com/pavelhritonenko/fspickler-newtonsoft - repository for reproduce issue
The text was updated successfully, but these errors were encountered: