Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variables are not properly set for make installcheck #817

Closed
jougs opened this issue Sep 4, 2017 · 0 comments · Fixed by #819
Closed

Environment variables are not properly set for make installcheck #817

jougs opened this issue Sep 4, 2017 · 0 comments · Fixed by #819
Assignees
@jougs
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation ZC: Infrastructure DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Milestone
NEST 2.14.0

Comments

@jougs
Copy link
Contributor

jougs commented Sep 4, 2017

The custom build targets configured in lines 189-207 of CMakeLists.txt set the environment variables PATH and PYTHONPATH. However, these are evaluated at configure time, not at run time as intended. The problem is explained in this stackoverflow question.

This leads to problems with executing tests that require external modules (e.g. using CSA), which require the PYTHONPATH to be set. Thus this should be fixed asap.

@w-klijn, @heplesser, @terhorstd
@jougs jougs added ZC: Infrastructure DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: Pending DO NOT USE THIS LABEL S: High Should be handled next T: Bug Wrong statements in the code or documentation labels Sep 4, 2017
@jougs jougs added this to the NEST 2.14.0 milestone Sep 4, 2017
@jougs jougs self-assigned this Sep 4, 2017
@heplesser heplesser mentioned this issue Sep 4, 2017
Merged
jougs added a commit to jougs/nest-simulator that referenced this issue Sep 6, 2017
@jougs
Properly set the environment variables for do_tests.sh
0c88692 
This changes the custom build target installcheck to only set the
configuration-specific part of the environment variables PATH and
PYTHONPATH. The bash script do_tests.sh then concatenates these
with the real environment variable. The way it was done before did
not actually work, but was setting the variables to the values at
configure time, instead of build time.

This fixes nest#817.
@jougs jougs mentioned this issue Sep 6, 2017
Merged
@jougs jougs closed this as completed in #819 Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jougs jougs

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation ZC: Infrastructure DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 2.14.0
Development

Successfully merging a pull request may close this issue.

Properly set the environment variables for do_tests.sh jougs/nest-simulator
1 participant
@jougs