Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing Read the docs build #2233

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Fix failing Read the docs build #2233

merged 4 commits into from
Dec 9, 2021

Conversation

jessica-mitchell
Copy link
Contributor

This PR fixes the build on Read the docs, that fails due changes when #2220 was merged.

Thanks to @Helveg for the fix

@jessica-mitchell jessica-mitchell added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. labels Dec 7, 2021
@terhorstd
Copy link
Contributor

The MacOS error is fixed in #2231, so that one needs to go in first.

@terhorstd terhorstd added the P: Blocked Work on this can not continue, see comments for the particular reason label Dec 7, 2021
steffengraber
steffengraber approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Build for me on Raedthedocs and local.
👍

@terhorstd terhorstd removed the request for review from Helveg December 9, 2021 13:27
terhorstd
terhorstd reviewed Dec 9, 2021
View reviewed changes
doc/userdoc/conf.py Outdated Show resolved Hide resolved
terhorstd
terhorstd reviewed Dec 9, 2021
View reviewed changes
doc/userdoc/conf.py Outdated Show resolved Hide resolved
@terhorstd terhorstd removed the P: Blocked Work on this can not continue, see comments for the particular reason label Dec 9, 2021
@terhorstd terhorstd merged commit 04acc1b into nest:master Dec 9, 2021
@steffengraber
Copy link
Contributor

Read the docs build is fixed now. Thanks!

@terhorstd terhorstd changed the title Fix failing Read the docs build Fix failing Read the docs build Jan 21, 2022
@jessica-mitchell jessica-mitchell deleted the test-conf branch April 17, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd left review comments

@steffengraber steffengraber steffengraber approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessica-mitchell @terhorstd @steffengraber