-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move NESTML documentation to ReadTheDocs #517
Conversation
Ah, sorry, I completely forgot I said I would take care of that...
No it's not, that's its main purpose so you can make it do pretty much anything ^^ what did you want to do ? |
Hi @Silmathoron, thanks for your thoughts. At some point during coding I just really wished I had the HTML API docs nearby; already forgot that we talked about it before! Re the distinction between NESTML and PyNESTML: should this API doc then not be called "PyNESTML API documentation", rather than "NESTML API documentation", as it pertains to the toolchain and not the language? As for human-written docs: I want to prevent the fragmentation of documents across too many places. This is why I suggested to keep the readthedocs page strictly for the API docs. Of course we can still do a lot better there by adding introductory text to the main modules (e.g. in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I noticed that some APIs have ellipses, where I assume some text will replace this at a later time?
-
A lot of the listed functions and classmethods contain no information (e.g.https://nestml-api-documentation.readthedocs.io/en/latest/pynestml.symbols.html#pynestml.symbols.predefined_functions.PredefinedFunctions) - not sure if these need to be here, should contain more information, or fine the way they are.
-
Some links contain empty files (e.g., https://nestml-api-documentation.readthedocs.io/en/latest/pynestml.codegeneration.resources_nest.setup.html and https://nestml-api-documentation.readthedocs.io/en/latest/pynestml.codegeneration.resources_nest.directives.html)
-
It looks to me that a lot of the markup is not generating properly
- like properties are not being displayed properly (e.g, see screenshot)
I would expect the :text: to be marked up differently. I'm not sure if the proper terms are being used here.
- Some other output that looks strange:
- Who is the intended audience? This feels like an internal reference file, which would only be suitable for those who know what's going on with the code.
A custom Pygments lexer was added to enable NESTML syntax highlighting on readthedocs. |
Merging after live review |
This PR adds the necessary files to make NESTML API documentation render on readthedocs.org.
Please see the rendered results (based on my personal fork) at: https://nestml-api-documentation.readthedocs.io/
The public-facing version of the documentation will be at https://nestml.readthedocs.io/
Sphinx is a little obtuse when it comes to the organisation into modules/submodules/packages. We therefore have limited room to play around with this. My current strategy is to have a minimal landing page, with a single link to the "pynestml" package, which then lists all subpackages and -modules. Is this acceptable to the reviewers?
Some rendering errors exist when converting the ReST-style docstrings to HTML. This will of course be addressed, but I would like to do this in a separate PR, where we can then tackle the specification of parameter and return types at the same time.
Open question: should we consistently refer to PyNESTML API documentation, as these documents pertain more to the toolchain than the language itself?
N.B. please squash these commits when merging!