Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits after the new analysis repo #180

Merged
merged 7 commits into from
Feb 17, 2023
Merged

Edits after the new analysis repo #180

merged 7 commits into from
Feb 17, 2023

Conversation

lizgzil
Copy link
Collaborator

@lizgzil lizgzil commented Feb 8, 2023

Now we have a new repo for the streamlit apps, some things can be got rid of here.


Thanks for contributing to Nesta's Skills Extractor Library 🙏!

If you have suggested changes to code anywhere outside of the ExtractSkills class, please consult the checklist below.

Checklist ✔️🐍:

  • I have refactored my code out from notebooks/
  • I have checked the code runs
  • I have tested the code
  • I have run pre-commit and addressed any issues not automatically fixed
  • I have merged any new changes from dev
  • I have documented the code
    • Major functions have docstrings
    • Appropriate information has been added to READMEs
  • I have explained the feature in this PR or (better) in output/reports/
  • I have requested a code review

If you have suggested changes to documentation (and/or the ExtractSkills class), please ALSO consult the checklist below.

Documentation Checklist ✔️📚:

  • I have run make html in docs
  • I have manually reviewed the docs/build/*.html files locally to ensure they have formatted correctly
  • I have pushed both relevant files AND their corresponding docs/build/*.html files

@lizgzil lizgzil mentioned this pull request Feb 8, 2023
13 tasks
@india-kerle
Copy link
Collaborator

@lizgzil - I've made the changes to include only top transversal skills but can't tag you as you opened the PR! Let me know if its ok to merge once you've had a look at the changes.

@lizgzil lizgzil marked this pull request as ready for review February 16, 2023 16:36
@india-kerle
Copy link
Collaborator

i think it's been successfully migrated @lizgzil !!

@lizgzil lizgzil merged commit 6351396 into dev Feb 17, 2023
@lizgzil lizgzil deleted the viz-after-new-repo branch February 17, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants