-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
201 update dependencies #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why download function has been overwritten / called twice?
Potential oversight?
Have tested, works perfectly for me. I would recommend removing aws cli section of readme like i did on my PR if mine doesn't get merged |
Windows Related Changes pt2 ( windows changes + aws cli replacement with boto3 )
I've had a deeper look at the version tagging implementation.
Further work that may be needed:
|
great - i was able to create a new env, install dependencies and use the libraries core functionality with no errors. Looks like all tests on ubuntu and windows passed as well. |
Thanks for contributing to Nesta's Skills Extractor Library 🙏!
If you have suggested changes to code anywhere outside of the ExtractSkills class, please consult the checklist below.
Checklist ✔️🐍:
notebooks/
(no notebook code involved)pre-commit
and addressed any issues not automatically fixeddev
README
soutput/reports/
If you have suggested changes to documentation (and/or the ExtractSkills class), please ALSO consult the checklist below.
Documentation Checklist ✔️📚:
make html
indocs
docs/build/*.html
files locally to ensure they have formatted correctlydocs/build/*.html
files