Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201 update dependencies #202

Merged
merged 43 commits into from
Oct 9, 2023
Merged

201 update dependencies #202

merged 43 commits into from
Oct 9, 2023

Conversation

sqr00t
Copy link
Contributor

@sqr00t sqr00t commented Sep 25, 2023

  • Removes awscli from requirements_dev.txt
  • Updates following dependencies:
    • numpy 1.22.4 -> 1.24.4
    • scipy 1.8.1 -> 1.10.1
    • scikit-learn 0.23.2 -> 1.3.1
  • Adapts @Aiden-RC 's snippet for download() function using boto3
  • Adds pip dependency caching for "Unit Tests" workflow
  • Adds windows-latest support to "Unit Tests" Actions workflow
  • Utilise Path objects in setup.py
  • Fixes cross-platform version tagging bug by:
    • Adding setuptools_scm to setup.py
    • Build config to a pyproject.toml file
  • Removes manually downloading base SpaCy model

Thanks for contributing to Nesta's Skills Extractor Library 🙏!

If you have suggested changes to code anywhere outside of the ExtractSkills class, please consult the checklist below.

Checklist ✔️🐍:

  • I have refactored my code out from notebooks/ (no notebook code involved)
  • I have checked the code runs
  • I have tested the code
  • I have run pre-commit and addressed any issues not automatically fixed
  • I have merged any new changes from dev
  • I have documented the code
    • Major functions have docstrings
    • Appropriate information has been added to READMEs
  • I have explained the feature in this PR or (better) in output/reports/
  • I have requested a code review

If you have suggested changes to documentation (and/or the ExtractSkills class), please ALSO consult the checklist below.

Documentation Checklist ✔️📚:

  • I have run make html in docs
  • I have manually reviewed the docs/build/*.html files locally to ensure they have formatted correctly
  • I have pushed both relevant files AND their corresponding docs/build/*.html files

Copy link
Contributor

@Aiden-RC Aiden-RC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why download function has been overwritten / called twice?
Potential oversight?

@Aiden-RC
Copy link
Contributor

Have tested, works perfectly for me.
As was running on windows had to make a few changes to get it to run ( that i had made previously but had to do a few other changes also to make it run on windows correctly.
New PR made for this at #204
contains this PR changes aswell as windows related changes and windows pytest actions.

I would recommend removing aws cli section of readme like i did on my PR if mine doesn't get merged

Windows Related Changes pt2 ( windows changes + aws cli replacement with boto3 )
README.md Show resolved Hide resolved
@sqr00t
Copy link
Contributor Author

sqr00t commented Oct 6, 2023

I've had a deeper look at the version tagging implementation.
Automatic versioning now should work across Windows and Mac:

  • Added using setuptools_scm for this feature
  • Added some build config in a new pyproject.toml file

Further work that may be needed:

  • Major/ Minor releases may need to have it's own branch created manually, as this automatically updates the fix/hotfix version. I'm having another look at this

@india-kerle
Copy link
Collaborator

great - i was able to create a new env, install dependencies and use the libraries core functionality with no errors. Looks like all tests on ubuntu and windows passed as well.

@india-kerle india-kerle merged commit 1cbf309 into dev Oct 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants