Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: let ConfigService type know about schema validation #676

Merged
merged 3 commits into from
Nov 3, 2021
Merged

feat: let ConfigService type know about schema validation #676

merged 3 commits into from
Nov 3, 2021

Commits on Oct 1, 2021

  1. feat(): let ConfigService type know about schema validation 

    Closes #668
    @micalevisk
    micalevisk committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    f6d4b6b View commit details
    Browse the repository at this point in the history

  2. feat(): do not expose the type utility ExcludeUndefinedIf

    @micalevisk
    micalevisk committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    259d793 View commit details
    Browse the repository at this point in the history

  3. test: add attempt to test the new feature added 

    Since there's no other way to check TypeScript types within this project
without addind some 3rd-party lib, I've made this approach: let TSC
complains about typings while running the npm-script `test:integration`.
    @micalevisk
    micalevisk committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    87972b3 View commit details
    Browse the repository at this point in the history