Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(openapi): prefer lazy over eager creation of the document #2704

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

H4ad
Copy link
Contributor

@H4ad H4ad commented Apr 17, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

NestJS does not use the new feature of lazy initialization of Swagger, which adds some time to startup.

Associated with nestjs/swagger#2392

What is the new behavior?

Now, by default, we use always the lazy initialization in favor of the initialization speed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Tony133
Copy link
Contributor

Tony133 commented Jun 18, 2023

This linked PR:nestjs/swagger#2392 is associated with this one and has been merged, so I would say merge this as well, right?

@micalevisk
Copy link
Member

micalevisk commented Jun 18, 2023

I guess we can merge this now 😸

@H4ad
Copy link
Contributor Author

H4ad commented Nov 6, 2023

@kamilmysliwiec Can we merge this PR, this change was merged a long time ago.

@Tony133 Tony133 mentioned this pull request Apr 1, 2024
@kamilmysliwiec kamilmysliwiec merged commit 5e49051 into nestjs:master Oct 17, 2024
@H4ad H4ad deleted the feat/lazy-swagger branch October 17, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants