-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(openapi): prefer lazy over eager creation of the document #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
micalevisk
approved these changes
Apr 17, 2023
rubiin
approved these changes
Apr 23, 2023
Tony133
approved these changes
May 16, 2023
This linked PR:nestjs/swagger#2392 is associated with this one and has been merged, so I would say merge this as well, right? |
I guess we can merge this now 😸 |
micalevisk
reviewed
Jul 3, 2023
micalevisk
approved these changes
Jul 9, 2023
rubiin
approved these changes
Jul 9, 2023
Tony133
approved these changes
Jul 9, 2023
@kamilmysliwiec Can we merge this PR, this change was merged a long time ago. |
micalevisk
approved these changes
Nov 8, 2023
Tony133
approved these changes
Nov 11, 2023
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
NestJS does not use the new feature of lazy initialization of Swagger, which adds some time to startup.
Associated with nestjs/swagger#2392
What is the new behavior?
Now, by default, we use always the lazy initialization in favor of the initialization speed.
Does this PR introduce a breaking change?
Other information