Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] name will lookup directly to the property instead of the getter function #673

Closed
leesiongchan opened this issue Mar 17, 2020 · 2 comments
Closed

[v7] name will lookup directly to the property instead of the getter function #673

leesiongchan opened this issue Mar 17, 2020 · 2 comments

Comments

@leesiongchan
Copy link

leesiongchan commented Mar 17, 2020 •
edited
Loading

I'm submitting a...


[x] Regression 
[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

It returns the id instead of the the relayId

Expected behavior

It should return the relayId

Minimal reproduction of the problem with instructions

Check out this repo bug/v7
Then run npm run test:integration --testPathPattern code-first.spec.ts$

And here is the commit

What is the motivation / use case for changing the behavior?

Want to map internal id to relay's global id

Environment


Nest version: 7

 
For Tooling issues:
- Node version: 13.9.0
- Platform:  Linux

Others:
@leesiongchan leesiongchan changed the title [v7] name alias will directly lookup to the property instead of the getter function [v7] name alias will lookup directly to the property instead of the getter function Mar 17, 2020
@leesiongchan leesiongchan changed the title [v7] name alias will lookup directly to the property instead of the getter function [v7] name will lookup directly to the property instead of the getter function Mar 17, 2020
kamilmysliwiec added a commit that referenced this issue Mar 18, 2020
@kamilmysliwiec
fix(): fix getters in object types #673
faad7cf
@kamilmysliwiec
Copy link
Member

Fixed in 7.0.8. Thanks for reporting

@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leesiongchan @kamilmysliwiec