fix: enable non-nullable, defaulted fields in code-first schema

[sam-super]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

When a not-nullable field has a defaultValue it generates a nullable input field:

@InputType()
export class AcmeInput {
  @Field({ nullable: false, defaultValue: 'foo' })
  bar: string;
}

it generates:

input AcmeInput {
  bar: String = "foo"
}

What is the new behavior?

The above will generate this schema:

input AcmeInput {
  bar: String! = "foo"
}

Does this PR introduce a breaking change?

• No

Other information

Some of the tests (e.g. the snapshots) capture the erroneous functionality, so to keep this PR specific to the change, some existing fields had nullable: true set to match the existing tests.

[kamilmysliwiec]

lgtm

[piotr-pawlowski]

This "fix" doesn't make sense to me. Now Apollo Kotlin doesn't allow to omit params with default values. Before this fix I could write foo = Input.absent() and I knew that the default value would be applied. Now I have to write foo = "bar", so my app needs to know what is default value for given param.
The second thing is that you wrote: "Does this PR introduce a breaking change? No". It's not true because from now on parameters with default values are non-nullable. So graphql-inspector marks these fields as breaking changes.
To keep backward compability I am required to add explicitly { nullable: true } to each field.

[zq0904]

I was using "@nestjs/graphql": "^10.1.3 ", but the online version updates automatically to 10.2.0

I have a large number of similar inputtypes

For example:
@inputType()
export class ProjectsOptPagingInput extends ProjectOptPagingInput {
@field(() => Int)
projectId: Project['id'] = 0;
}

This change is a destructive change. I would like to know why it was modified. Is the same with version 11?

[wodka]

How can this be in a patch release? it completely breaks the old behaviour of defaultValue! Now per default all are mandatory, whereas they have been optional!

-> this should be mentioned as a breaking change and should have been released in v11!