Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): subscription.subscribe() not copied #667

Merged
merged 1 commit into from
Mar 15, 2020
Merged

fix(): subscription.subscribe() not copied #667

merged 1 commit into from
Mar 15, 2020

Conversation

igrek8
Copy link

@igrek8 igrek8 commented Mar 15, 2020

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Methods decorated with @Subscription are not copied into the resolvers. As a result, AsyncIterator is not returned causing Subscription field must return Async Iterable. Received: undefined

Issue Number: 663

What is the new behavior?

References to methods are copied accordingly. Subscribers subscribe to AsyncIterators and receive updates.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copying subscribe() does not affect any resolvers.

@igrek8
Copy link
Author

igrek8 commented Mar 15, 2020

#663

@kamilmysliwiec
Copy link
Member

Thank you!

@kamilmysliwiec kamilmysliwiec merged commit 18ee9ed into nestjs:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants