Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align MongooseModuleOptions with MongooseModuleAsyncOptions #244

Closed
BorntraegerMarc opened this issue Jan 26, 2020 · 1 comment
Closed

Comments

@BorntraegerMarc
Copy link
Contributor

BorntraegerMarc commented Jan 26, 2020

I'm submitting a...


[ ] Regression 
[ ] Bug report
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Expected behavior

We should refactor the forRoot method to not have the first param uri. And make the URI non-optional in the MongooseModuleOptions. Then we could safe this if statement. This would also have the advantage that the forRoot method and the MongooseModuleAsyncOptions have the same params. Which feels better for me.

Minimal reproduction of the problem with instructions

None.

What is the motivation / use case for changing the behavior?

Better alignment of params. This would introduce breaking changes.

Environment


Nest version: 6.X

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@BorntraegerMarc BorntraegerMarc changed the title $A Align MongooseModuleOptions with MongooseModuleAsyncOptions Jan 26, 2020
BorntraegerMarc added a commit to BorntraegerMarc/mongoose that referenced this issue Jan 26, 2020
BorntraegerMarc added a commit to BorntraegerMarc/mongoose that referenced this issue Jan 26, 2020
Fixes nestjs#244

BREAKING CHANGE: Removed URI param in MongooseCoreModule.forRoot and made it non-optional in option object
@kamilmysliwiec
Copy link
Member

#245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants