You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[ ] Regression
[ ] Bug report
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
Current behavior
Expected behavior
We should refactor the forRoot method to not have the first param uri. And make the URI non-optional in the MongooseModuleOptions. Then we could safe this ifstatement. This would also have the advantage that the forRoot method and the MongooseModuleAsyncOptions have the same params. Which feels better for me.
Minimal reproduction of the problem with instructions
None.
What is the motivation / use case for changing the behavior?
Better alignment of params. This would introduce breaking changes.
Environment
Nest version: 6.X
For Tooling issues:
- Node version: XX
- Platform:
Others:
The text was updated successfully, but these errors were encountered:
BorntraegerMarc
changed the title
$A
Align MongooseModuleOptions with MongooseModuleAsyncOptions
Jan 26, 2020
I'm submitting a...
Current behavior
Expected behavior
We should refactor the forRoot method to not have the first param
uri
. And make the URI non-optional in the MongooseModuleOptions. Then we could safe thisif
statement. This would also have the advantage that theforRoot
method and theMongooseModuleAsyncOptions
have the same params. Which feels better for me.Minimal reproduction of the problem with instructions
None.
What is the motivation / use case for changing the behavior?
Better alignment of params. This would introduce breaking changes.
Environment
The text was updated successfully, but these errors were encountered: