Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(): load configuration via same entry #1421

Conversation

zanminkian
Copy link
Contributor

@zanminkian zanminkian commented Nov 23, 2021

As the commit msg, this PR is to let actions load nest-cli configuration via same entrance.

If you don't like it, please let me know. Thanks a lot.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The attribute loader in BuildAction class is protected and I deleted it. Therefore, it may cause breaking change if third-party cli action has extended BuildAction.

@zanminkian
Copy link
Contributor Author

If this PR is accepted, it will be easy to validate nest-cli.json. #692

We can validate it after it's loaded.

@kamilmysliwiec
Copy link
Member

If this PR is accepted, it will be easy to validate nest-cli.json. #692
We can validate it after it's loaded.

Would you like to create a follow-up PR (using this PR as a base) to implement this feature?

@zanminkian
Copy link
Contributor Author

If this PR is accepted, it will be easy to validate nest-cli.json. #692
We can validate it after it's loaded.

Would you like to create a follow-up PR (using this PR as a base) to implement this feature?

Sure. I will do this in 3 days.

@zanminkian zanminkian marked this pull request as draft November 24, 2021 12:58
@zanminkian
Copy link
Contributor Author

@kamilmysliwiec New PR is #1427 . : )

@zanminkian zanminkian closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants