Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no change in the treatment between string and object response of HttpException #1339

Closed
IsraelZablianov opened this issue Dec 5, 2018 · 3 comments
Closed

There is no change in the treatment between string and object response of HttpException #1339

IsraelZablianov opened this issue Dec 5, 2018 · 3 comments
Labels
scope: common status: done 👏 type: bug 😭

Comments

@IsraelZablianov
Copy link

nest/packages/common/exceptions/http.exception.ts

Line 11 in d5dca17

* When `response` is a string:

When response is a string or object the same behavior is applied, in contrast to what is written in the comment.
kamilmysliwiec added a commit that referenced this issue Dec 5, 2018
@kamilmysliwiec
bugfix(common): custom exception body #1339
411db0c
@kamilmysliwiec kamilmysliwiec mentioned this issue Dec 5, 2018
Merged
3 tasks
@kamilmysliwiec
Copy link
Member

Thanks for reporting!

kamilmysliwiec added a commit that referenced this issue Dec 6, 2018
@kamilmysliwiec
Merge pull request #1344 from nestjs/bugfix/1339-exceptions
6a54900 
bugfix(common): custom exception body #1339
@kamilmysliwiec
Copy link
Member

Fixed in 5.5.0 :)

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope: common status: done 👏 type: bug 😭
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IsraelZablianov @kamilmysliwiec