Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CircleCI as replacement of TravisCI #2720

Closed
BrunnerLivio opened this issue Aug 8, 2019 · 8 comments
Closed

Use CircleCI as replacement of TravisCI #2720

BrunnerLivio opened this issue Aug 8, 2019 · 8 comments

Comments

@BrunnerLivio
Copy link
Member

Feature Request

What is the motivation / use case for changing the behavior?

TravisCI is great for smaller projects and easy to get started with. In my opinion NestJS has grown out of this.

Some features why choose CircleCI over TravisCI:

  • YAML Anchors: Allows to define "mixin" jobs. It allows to reduce redundancy. Useful for e.g. setup the environment and saving / restoring cache.
  • Displays each job on GitHub:
    Selection_001
  • Better measuring:
    Selection_002
  • Better workflow integration:
    Selection_003

Teachability, Documentation, Adoption, Migration Strategy

Migrate nestjs/nest to CircleCI. Migrate integrations only if needed.

@kamilmysliwiec
Copy link
Member

I wanted to migrate over CircleCI for months! :) Let's do it as soon as possible. Feel free to move forward with this migration if you have some spare time.

@marcus-sa
Copy link

marcus-sa commented Aug 14, 2019

Let me know if you need any help, since this will affect #2743 aswell 🥳

@kamilmysliwiec
Copy link
Member

I started the migration towards CircleCI. Feel free to contribute:)

@BrunnerLivio
Copy link
Member Author

@kamilmysliwiec looking really nice - exactly how I had imagined it to be (with the mixins / aliases, etc. so awesome) :)

The checks are so useful for a contributor:
awesomeness
awesomeness 2

and the config is way cleaner and maintainable.

@marcus-sa

This comment has been minimized.

@BrunnerLivio

This comment has been minimized.

@kamilmysliwiec
Copy link
Member

Just finished the migration of the main repo. I'll do the same for the rest of them too. If anyone wants to contribute, PRs are welcome!

PS. @BrunnerLivio I think that @marcus-sa asked about NPM vs Yarn, not Yarn workspaces. I'm personally using NPM recently, but I don't have any preference here. Both aren't perfect, neither one convinced me, so I'm just using this one which is more popular now:)

@lock
Copy link

lock bot commented Nov 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants