Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(): refactor exception handlers #10133

Merged
merged 10 commits into from
Apr 5, 2023

Conversation

TheKhanj
Copy link
Contributor

@TheKhanj TheKhanj commented Aug 18, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Aug 18, 2022

Pull Request Test Coverage Report for Build 45e90302-44ea-46ab-a87d-288a57a77905

  • 13 of 13 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 93.808%

Totals Coverage Status
Change from base Build ec438b34-a56e-4f82-ae11-45373f207a16: -0.004%
Covered Lines: 6090
Relevant Lines: 6492

💛 - Coveralls

@TheKhanj
Copy link
Contributor Author

Any opinion about these changes?🤔

@kamilmysliwiec kamilmysliwiec added this to the 10.0.0 milestone Apr 5, 2023
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 10.0.0 April 5, 2023 11:14
@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 77442c8 into nestjs:10.0.0 Apr 5, 2023
@TheKhanj
Copy link
Contributor Author

TheKhanj commented Apr 5, 2023

Tnx 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants