Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): streamable file for headers already sent case #10895

Closed
wants to merge 1 commit into from

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #10681

What is the new behavior?

the app won't crash anymore on headers already sent errors

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build eb2d74ad-5b78-4f40-8cb4-c6eeb4a0a8b1

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 93.347%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/common/file-stream/streamable-file.ts 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
packages/microservices/listener-metadata-explorer.ts 2 87.1%
packages/core/injector/container.ts 9 88.89%
Totals Coverage Status
Change from base Build 43c8609d-7c9b-40c5-85e1-094c9c517952: -0.06%
Covered Lines: 6202
Relevant Lines: 6644

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes if StreamableFile stream has error mid-stream
4 participants