Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): inject decorator should allow key to be undefined #10970

Merged
merged 2 commits into from
Feb 1, 2023
Merged

fix(common): inject decorator should allow key to be undefined #10970

merged 2 commits into from
Feb 1, 2023

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec mentioned this pull request Jan 27, 2023
Closed
15 tasks
@coveralls
Copy link

coveralls commented Jan 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 98c608b3-de6f-420d-9005-0cb6aab9f265

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.409%
Totals Coverage Status
Change from base Build 3995954d-8a28-41bd-aed6-d1836b737f1e: 0.0%
Covered Lines: 6207
Relevant Lines: 6645
💛 - Coveralls

@DanielRosenwasser
Copy link

DanielRosenwasser commented Jan 27, 2023 •
edited
Loading

Does Optional need a fix?

nest/packages/common/decorators/core/optional.decorator.ts

Lines 20 to 21 in e4bd87b

export function Optional() {
return (target: object, key: string | symbol, index?: number) => {

@kamilmysliwiec kamilmysliwiec merged commit 268d930 into master Feb 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/inject-decorator-signature branch February 1, 2023 10:30
@samesfahani-tuplehealth samesfahani-tuplehealth mentioned this pull request Feb 2, 2023
Closed
tychota added a commit to tychota/mikro-orm-nestjs that referenced this pull request Mar 24, 2023
@tychota
chore(deps): upgrade nest dependencies
79eba68 
This allow support of Typescript 5, that were fixed in
nestjs/nest#10970 and merged
in 9.3.0
@CatsMiaow CatsMiaow mentioned this pull request Mar 27, 2023
Closed
@msimon msimon mentioned this pull request Apr 3, 2023
Closed
4 tasks
@Nicklason Nicklason mentioned this pull request Apr 7, 2023
Merged
willsoto pushed a commit to willsoto/nestjs-prometheus that referenced this pull request Apr 7, 2023
@Nicklason
fix: decorator types (#1685)
6f8a52e 
I found this issue #1667 that had the same errors as me, but the comments didn't help. I also found a different issue nestjs/nest#10959, and the fix they used nestjs/nest#10970, and used that to fix the problem with the InjectMetric decorator.

The problem is that the decorator types are wrong. Record<string, unknown> fails with strict checks, and the key may also be undefined.

Fixes #1667
@ttshivers ttshivers mentioned this pull request Apr 9, 2023
Open
This was referenced Apr 10, 2023
Closed
Merged
Merged
@HansMusterWhatElse HansMusterWhatElse mentioned this pull request May 19, 2023
Closed
@svtslv svtslv mentioned this pull request Jun 12, 2023
Open
@baumerdev baumerdev mentioned this pull request Jul 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tony133 Tony133 Tony133 approved these changes

Assignees
No one assigned
Labels
scope: common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamilmysliwiec @coveralls @DanielRosenwasser @Tony133