Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): update log level #11036

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Feb 3, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #10878

What is the new behavior?

  • Updated the log level value

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Note: PR for the next major version of NestJS 😻 (Not merge at the moment)

@Tony133
Copy link
Contributor Author

Tony133 commented Feb 3, 2023

In the old PR I had also moved the ConsoleLoggerOptions interface to a separate file, here I did not move it if you want I can move it otherwise it stays as it is now, for no problem. 👍

However I will check the files that are missing to add @ApiPublic so contributors like me have no problem figuring out which are public or private

@coveralls
Copy link

Pull Request Test Coverage Report for Build e36ebc3b-d34a-4399-8e04-84419c5085b4

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.957%

Totals Coverage Status
Change from base Build 4a75247a-671a-472c-a4bc-e84b7f7d9902: 0.0%
Covered Lines: 6414
Relevant Lines: 6900

💛 - Coveralls

@micalevisk
Copy link
Member

since this introduces breaking changes (as per Kamil's comment), can you update that checkbox on PR's description? ~ just to clarify for future readers

I'll label this accordingly.

@Tony133
Copy link
Contributor Author

Tony133 commented Apr 5, 2023

Can we add it in this branch https://github.com/nestjs/nest/tree/10.0.0 ?

@kamilmysliwiec kamilmysliwiec merged commit 404e2c7 into nestjs:master Jun 12, 2023
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants