feat(common): define type for file input

[mohamadrezamomeni]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[coveralls]

Pull Request Test Coverage Report for Build ed678257-d3f2-408a-b523-68e1532a63e1

• 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
• 29 unchanged lines in 8 files lost coverage.
• Overall coverage increased (+0.03%) to 92.954%

---

Files with Coverage Reduction	New Missed Lines	%
packages/core/inspector/deterministic-uuid-registry.ts	1	75.0%
packages/core/router/paths-explorer.ts	1	91.3%
packages/websockets/exceptions/base-ws-exception-filter.ts	1	92.86%
packages/websockets/gateway-metadata-explorer.ts	1	88.46%
packages/microservices/listener-metadata-explorer.ts	2	87.1%
packages/core/injector/instance-wrapper.ts	3	93.93%
packages/common/pipes/validation.pipe.ts	4	90.22%
packages/core/scanner.ts	16	87.17%

Totals
Change from base Build 87b1d40c-8c24-4710-8c62-a3137e8d2971:	0.03%
Covered Lines:	6412
Relevant Lines:	6898

---

💛 - Coveralls

[mohamadrezamomeni]

define type for file details input in pipes

[micalevisk]

as FileTypeValidator is a public API, this PR introduces breaking changes.

[mohamadrezamomeni]

as FileTypeValidator is a public API, this PR introduces breaking changes.

thank you for comment.

[mohamadrezamomeni]

as FileTypeValidator is a public API, this PR introduces breaking changes.
i want to change any type for file to specific interface. then write unit test based on this interface. is it acceptable?

[kamilmysliwiec]

@thiagomini want to take a look? 👀

[micalevisk]

@mohamadrezamomeni sounds good

[thiagomini]

Thank you for your contribution! I think we only need to adjust a few things, tho. Check my suggestions below.

[mohamadrezamomeni]

@thiagomini what is your opinion right now ? :)

[thiagomini]

Hey, man, I'll review this PR again tomorrow. The last two days have been quite busy around here 😅. Thanks again for the contribution.

[thiagomini]

This LGTM now, but there's only one question left: why did you add the || { } in the generic type?

[mohamadrezamomeni]

This LGTM now, but there's only one question left: why did you add the || { } in the generic type?

It is issue i put || { } because according to the test input of isValue may be empty object. can you guide me what to do for this problem? i wanted to use // // @ts-ignore in unit test but i don't know it is good idea or no

[thiagomini]

This LGTM now, but there's only one question left: why did you add the || { } in the generic type?

It is issue i put || { } because according to the test input of isValue may be empty object. can you guide me what to do for this problem? i wanted to use // // @ts-ignore in unit test but i don't know it is good idea or no

I think we don't have to be explicit about that. The any case should already cover it.

[mohamadrezamomeni]

I think we don't have to be explicit about that. The any case should already cover it.

do it :)

[mohamadrezamomeni]

@kamilmysliwiec do you have any opinion right now?

[kamilmysliwiec]

@mohamadrezamomeni this is a breaking change so we must wait till the next major release