Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common)!: drop deprecated misspelled constant CUSTOM_ROUTE_AGRS_METADATA #11450

Merged

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Apr 11, 2023

I'm not sure if we will drop the deprecated methods on core/metadata-scanner.ts in v10

* @deprecated
* @see {@link getAllMethodNames}
* @see getAllMethodNames
*/
public scanFromPrototype<T extends Injectable, R = any>(

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build be8c3234-096b-4f53-b7df-2368e0c49079

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 92.996%

Totals Coverage Status
Change from base Build f1f54939-2381-4e11-8dbf-87dd557b7b30: -0.001%
Covered Lines: 6267
Relevant Lines: 6739

💛 - Coveralls

@micalevisk
Copy link
Member Author

I can't tell why the pipeline is failing:

image

@micalevisk micalevisk added this to the 10.0.0 milestone Apr 11, 2023
@Tony133
Copy link
Contributor

Tony133 commented Apr 11, 2023

The CI fails, but it is not related to the change you made.

But if you make the switch on the master branch, does the CI fail? (This is just an experiment 😄)

For core/metadata-scanner.ts, best to ask Kamil since it's about the part "Core"

@kamilmysliwiec
Copy link
Member

I'm aware of this error - we can ignore it for this PR :) LGTM

@micalevisk
Copy link
Member Author

@ihazar please report that to @nestjsx/crud-typeorm, it doesn't seems to be related tho this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants